Repository navigation
fix(deps): hold the conventional commits preset at version 9 - #142
Merged
Merged
Conversation
Version 10 of the preset needs conventional-changelog-writer 9, while the newest semantic-release notes generator still loads writer 8, so every release failed while rendering notes. A test now renders release notes through the generator and the preset, which is where the mismatch shows up before a release runs.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
|
🎉 This PR is included in version 1.41.4 🎉 The release is available on:
Installationnpm install -g markmv@1.41.4Security & Supply Chain✅ OIDC Trusted Publishing: published from CI with no long-lived npm token Test CoverageThis release includes comprehensive test coverage reports. View coverage details in the release assets. Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release job on main fails while semantic-release validates its plugins: conventional-changelog-conventionalcommits 10 requires conventional-changelog-writer 9 or newer, and @semantic-release/release-notes-generator (14.1.1, the latest) still depends on writer ^8, so the preset cannot render. The dependency upgrade moved the preset to 10; I should have run a semantic-release dry run after upgrading release plugins and did not.
The preset goes back to ^9. A new test renders release notes through the generator and the preset, so the mismatch fails in CI rather than during a release; it failed with the production error before the pin and passes after. The generator is now a direct dev dependency with a small declaration, since the test imports it. Moving the preset to 10 is tracked in #143 and needs a generator release on writer 9.